Fix: Validate OAuth state parameter on Discord login callback (#1157) - #1317
Merged
Merged
Conversation
…ode#1157) - Replace weak Math.random() state generation with cryptographically secure CSPRNG (256-bit entropy) - Use constant-time comparison for state validation to prevent timing attacks - Update Discord OAuth callback to use validateOAuthState from security middleware - Add comprehensive tests for secure state generation and validation - Fix redirect status code test expectation (302 -> 307) This prevents CSRF attacks by ensuring the OAuth state parameter is properly generated and validated during the Discord OAuth flow.
|
@DavisVT Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents CSRF attacks by ensuring the OAuth state parameter is properly generated and validated during the Discord OAuth flow.
closes #1157